feat(F-095): completed feature
This commit is contained in:
@@ -4264,6 +4264,41 @@
|
||||
"close": true
|
||||
},
|
||||
"completed_at": "2026-08-20T20:01:54Z"
|
||||
},
|
||||
{
|
||||
"id": "F-095",
|
||||
"type": "fix",
|
||||
"title": "Download remote image URL before attaching product image",
|
||||
"problem": "Adding an external image URL from the admin product editor sends the URL directly to the attach endpoint, and an unnecessary empty product PATCH causes HTTP 400. External images should be downloaded to local uploads before being attached so they remain available and are mirrored to the other apps.",
|
||||
"goal": "Make Add URL download a validated remote image through the admin upload route, store it locally, then attach the local uploads URL to the product. Remove the erroneous empty product update.",
|
||||
"scope_in": [
|
||||
"admin image editor upload route and product image attachment"
|
||||
],
|
||||
"scope_out": [
|
||||
"No arbitrary non-image downloads",
|
||||
"no private network access",
|
||||
"no external URL stored as the product image"
|
||||
],
|
||||
"priority": "high",
|
||||
"risk": "low",
|
||||
"description": "Problem: Adding an external image URL from the admin product editor sends the URL directly to the attach endpoint, and an unnecessary empty product PATCH causes HTTP 400. External images should be downloaded to local uploads before being attached so they remain available and are mirrored to the other apps.. Goal: Make Add URL download a validated remote image through the admin upload route, store it locally, then attach the local uploads URL to the product. Remove the erroneous empty product update.. Scope IN: admin image editor upload route and product image attachment. Scope OUT: No arbitrary non-image downloads, no private network access, no external URL stored as the product image. Type: fix. Priority: high. Risk: low.",
|
||||
"acceptance": [
|
||||
"- Valid remote image URL is downloaded and stored under local uploads",
|
||||
"- Local uploads URL is attached to the product after download",
|
||||
"- Invalid/non-image/oversized URLs return a clear error",
|
||||
"- Private/local network URLs are rejected",
|
||||
"- Existing file upload flow remains working",
|
||||
"- Admin typecheck/lint and verify.sh pass"
|
||||
],
|
||||
"status": "done",
|
||||
"created_at": "2026-08-20",
|
||||
"gates": {
|
||||
"reviewer": true,
|
||||
"security": true,
|
||||
"qa": true,
|
||||
"close": true
|
||||
},
|
||||
"completed_at": "2026-08-20T20:05:54Z"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user