feat(F-088): completed feature

This commit is contained in:
chattie
2026-08-20 21:29:14 +02:00
parent 63fdc775d9
commit 699c01ade5
40 changed files with 996 additions and 381 deletions

View File

@@ -4024,6 +4024,41 @@
"close": true
},
"completed_at": "2026-08-20T04:16:38Z"
},
{
"id": "F-088",
"type": "fix",
"title": "Admin taxApi.update type signature missing appliesTo (F-085 regression)",
"problem": "F-085 added inline TIPO edit calling taxApi.update(id, { appliesTo }) but forgot to extend the Partial<{name,ratePercent,active}> type signature in apps/admin/src/lib/api-client.ts. tsc fails with TS2353, next build produces no BUILD_ID, and the admin process exits immediately on every monolith start, so http://192.168.18.93:3004/ returns ERR_CONNECTION_REFUSED.",
"goal": "Extend taxApi.update signature to accept appliesTo typed as the same enum used by the backend Zod schema ('general' | 'reduced' | 'super-reduced'). Unblocks admin production build, lets the admin stay alive on port 3004, and makes F-085's TIPO editing actually compile and ship.",
"scope_in": [
"project/apps/admin/src/lib/api-client.ts"
],
"scope_out": [
"No backend change (already supports appliesTo)",
"no new tax-type values",
"no DB schema change"
],
"priority": "high",
"risk": "low",
"description": "Problem: F-085 added inline TIPO edit calling taxApi.update(id, { appliesTo }) but forgot to extend the Partial<{name,ratePercent,active}> type signature in apps/admin/src/lib/api-client.ts. tsc fails with TS2353, next build produces no BUILD_ID, and the admin process exits immediately on every monolith start, so http://192.168.18.93:3004/ returns ERR_CONNECTION_REFUSED.. Goal: Extend taxApi.update signature to accept appliesTo typed as the same enum used by the backend Zod schema ('general' | 'reduced' | 'super-reduced'). Unblocks admin production build, lets the admin stay alive on port 3004, and makes F-085's TIPO editing actually compile and ship.. Scope IN: project/apps/admin/src/lib/api-client.ts. Scope OUT: No backend change (already supports appliesTo), no new tax-type values, no DB schema change. Type: fix. Priority: high. Risk: low.",
"acceptance": [
"- taxApi.update accepts appliesTo as 'general' | 'reduced' | 'super-reduced'",
"- npx tsc --noEmit in apps/admin exits 0",
"- npm run build in apps/admin produces .next/BUILD_ID",
"- admin process stays alive (PID running) after monolith restart",
"- curl http://127.0.0.1:3004/ returns 200",
"- verify.sh green"
],
"status": "done",
"created_at": "2026-08-20",
"gates": {
"reviewer": true,
"security": true,
"qa": true,
"close": true
},
"completed_at": "2026-08-20T19:29:14Z"
}
]
}