rikrdo/mercadodevida
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(F-088): completed feature

Browse Source
This commit is contained in:
chattie
2026-08-20 21:29:14 +02:00
parent 63fdc775d9
commit 699c01ade5
40 changed files with 996 additions and 381 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
work/artifacts/F-080/reviewer.json
View File

@@ -2,16 +2,44 @@
"feature_id": "F-080",
"verdict": "APPROVED",
"checks": [
{ "name": "PVP value bound to state, not derived", "result": "PASS", "notes": "PVP <input> value reads from gross[v.id], not from centsToEur(... netCents * (1 + rate)) on each render." },
{ "name": "type=text + inputMode=decimal", "result": "PASS", "notes": "All 4 price inputs (coste, PVP, oferta, neto) switched to type=text inputMode=decimal; comma and dot accepted." },
{ "name": "net <-> gross cross-sync on edit", "result": "PASS", "notes": "PVP onChange derives net; Neto onChange derives gross; IVA onChange recomputes gross from net using new rate." },
{ "name": "savePrice prefers gross and persists correctly", "result": "PASS", "notes": "savePrice now reads gross, converts to net via rate, posts to pricingApi.setVariantPrice. No API contract change." },
{ "name": "Pre-existing lint cleaned up", "result": "PASS", "notes": "Removed unused PricingSectionProps interface, unused loadingPrices and prices states (pre-existing) so lint is green." },
{ "name": "Margin still computed from gross", "result": "PASS", "notes": "calcMarginBruto(grossCents, costCents) uses eurToCents(gross[v.id]) — no longer recomputed on every render from netCents." }
{
"name": "PVP value bound to state, not derived",
"result": "PASS",
"notes": "PVP <input> value reads from gross[v.id], not from centsToEur(... netCents * (1 + rate)) on each render."
},
{
"name": "type=text + inputMode=decimal",
"result": "PASS",
"notes": "All 4 price inputs (coste, PVP, oferta, neto) switched to type=text inputMode=decimal; comma and dot accepted."
},
{
"name": "net <-> gross cross-sync on edit",
"result": "PASS",
"notes": "PVP onChange derives net; Neto onChange derives gross; IVA onChange recomputes gross from net using new rate."
},
{
"name": "savePrice prefers gross and persists correctly",
"result": "PASS",
"notes": "savePrice now reads gross, converts to net via rate, posts to pricingApi.setVariantPrice. No API contract change."
},
{
"name": "Pre-existing lint cleaned up",
"result": "PASS",
"notes": "Removed unused PricingSectionProps interface, unused loadingPrices and prices states (pre-existing) so lint is green."
},
{
"name": "Margin still computed from gross",
"result": "PASS",
"notes": "calcMarginBruto(grossCents, costCents) uses eurToCents(gross[v.id]) — no longer recomputed on every render from netCents."
}
],
"lint": { "errors_introduced": 0, "pre_existing_cleaned": true },
"lint": {
"errors_introduced": 0,
"pre_existing_cleaned": true
},
"typecheck": "PASS",
"verdict_reason": "PVP is now a free-text controlled input, mirrors Neto behavior, save uses gross. UI-only change, no API contract change.",
"reviewer": "reviewer",
"reviewed_at": "2026-08-20T04:01:00Z"
}
"reviewed_at": "2026-08-20T04:01:00Z",
"agent": "reviewer"
}