feat(F-086): completed feature
This commit is contained in:
18
work/artifacts/F-086/reviewer.json
Normal file
18
work/artifacts/F-086/reviewer.json
Normal file
@@ -0,0 +1,18 @@
|
||||
{
|
||||
"feature_id": "F-086",
|
||||
"verdict": "APPROVED",
|
||||
"checks": [
|
||||
{ "name": "Migration adds nullable DATE column", "result": "PASS", "notes": "033_product_expiration_date.js uses pgm.addColumn with notNull:false." },
|
||||
{ "name": "Domain and repository expose expirationDate", "result": "PASS", "notes": "Product type updated, ProductRow updated, toProduct and INSERT include the column, UPDATABLE includes it." },
|
||||
{ "name": "API accepts the field", "result": "PASS", "notes": "newProductSchema in catalog.routes.ts has z.iso.date().optional().nullable()." },
|
||||
{ "name": "Admin product editor has a date input", "result": "PASS", "notes": "ProductEditor renders <input type=\"date\"> with the field label and includes it in the save payload." },
|
||||
{ "name": "/products listing shows the new column", "result": "PASS", "notes": "Caducidad column added with formatted date and red highlighting when expired." },
|
||||
{ "name": "Tests pass", "result": "PASS", "notes": "9/9 catalog tests pass." }
|
||||
],
|
||||
"lint": { "errors_introduced": 0 },
|
||||
"typecheck": "PASS",
|
||||
"tests": "9/9 passed",
|
||||
"verdict_reason": "End-to-end expiration date at product level. DB, API, admin editor and listing all in place.",
|
||||
"reviewer": "reviewer",
|
||||
"reviewed_at": "2026-08-20T04:15:00Z"
|
||||
}
|
||||
Reference in New Issue
Block a user