From 8f02d1c6cce79bd3205aa8bd8f7fd29e5099f60a Mon Sep 17 00:00:00 2001
From: chattie <chattie@macmini-ai.local>
Date: Sat, 22 Aug 2026 19:13:31 +0200
Subject: [PATCH] feat(F-170): completed feature

---
 backlog/features.json                         | 12 +++++----
 .../src/app/(dashboard)/categories/page.tsx   | 26 +++++++++++++------
 project/apps/admin/src/lib/api-client.ts      |  1 +
 work/artifacts/F-170/architect.md             |  3 +++
 work/artifacts/F-170/documenter.md            |  3 +++
 work/artifacts/F-170/implementer.md           |  3 +++
 work/artifacts/F-170/leader-close.json        |  1 +
 work/artifacts/F-170/qa.json                  |  1 +
 work/artifacts/F-170/reviewer.json            |  1 +
 work/artifacts/F-170/security.json            |  1 +
 work/current.md                               |  4 +--
 work/runtime-status.json                      | 24 ++++++++---------
 12 files changed, 53 insertions(+), 27 deletions(-)
 create mode 100644 work/artifacts/F-170/architect.md
 create mode 100644 work/artifacts/F-170/documenter.md
 create mode 100644 work/artifacts/F-170/implementer.md
 create mode 100644 work/artifacts/F-170/leader-close.json
 create mode 100644 work/artifacts/F-170/qa.json
 create mode 100644 work/artifacts/F-170/reviewer.json
 create mode 100644 work/artifacts/F-170/security.json

diff --git a/backlog/features.json b/backlog/features.json
index 35a89b9..2bfb077 100644
--- a/backlog/features.json
+++ b/backlog/features.json
@@ -6902,13 +6902,15 @@
       "description": "Categories admin delete action does not work; restore guarded deletion and clear error feedback.",
       "priority": "high",
       "risk": "med",
-      "status": "pending",
+      "status": "done",
       "created_at": "2026-08-22",
       "gates": {
-        "reviewer": false,
-        "security": false,
-        "qa": false
-      }
+        "reviewer": true,
+        "security": true,
+        "qa": true,
+        "close": true
+      },
+      "completed_at": "2026-08-22T17:13:31Z"
     },
     {
       "id": "F-171",
diff --git a/project/apps/admin/src/app/(dashboard)/categories/page.tsx b/project/apps/admin/src/app/(dashboard)/categories/page.tsx
index 8b974a8..9a2d8e4 100644
--- a/project/apps/admin/src/app/(dashboard)/categories/page.tsx
+++ b/project/apps/admin/src/app/(dashboard)/categories/page.tsx
@@ -12,7 +12,7 @@ function slugify(text: string): string {
     .replace(/^-+|-+$/g, '');
 }
 
-function CategoryRow({ cat, onEdit, onDelete }: { cat: Category; onEdit: (c: Category) => void; onDelete: (id: string) => void }) {
+function CategoryRow({ cat, onEdit, onDelete, deleting }: { cat: Category; onEdit: (c: Category) => void; onDelete: (category: Category) => void; deleting: boolean }) {
   return (
     <tr className="hover:bg-gray-50 transition-colors">
       <td className="px-4 py-3">
@@ -45,7 +45,7 @@ function CategoryRow({ cat, onEdit, onDelete }: { cat: Category; onEdit: (c: Cat
               <path strokeLinecap="round" strokeLinejoin="round" d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z" />
             </svg>
           </button>
-          <button onClick={() => onDelete(cat.id)} className="p-1.5 text-gray-400 hover:text-red-600 hover:bg-red-50 rounded-lg transition-colors" title="Eliminar">
+          <button disabled={deleting} onClick={() => onDelete(cat)} className="p-1.5 text-gray-400 hover:text-red-600 hover:bg-red-50 rounded-lg transition-colors disabled:cursor-wait disabled:opacity-40" title="Eliminar">
             <svg className="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor" strokeWidth={2}>
               <path strokeLinecap="round" strokeLinejoin="round" d="M19 7l-.867 12.142A2 2 0 0116.138 21H7.862a2 2 0 01-1.995-1.858L5 7m5 4v6m4-6v6m1-10V4a1 1 0 00-1-1h-4a1 1 0 00-1 1v3M4 7h16" />
             </svg>
@@ -117,6 +117,7 @@ export default function CategoriesPage() {
   const [form, setForm] = useState<FormState>(EMPTY_FORM);
   const [saving, setSaving] = useState(false);
   const [generating, setGenerating] = useState(false);
+  const [deletingId, setDeletingId] = useState<string | null>(null);
   const [msg, setMsg] = useState('');
 
   const load = useCallback(async () => {
@@ -239,13 +240,22 @@ export default function CategoriesPage() {
     }
   };
 
-  const handleDelete = async (id: string) => {
-    if (!confirm('¿Eliminar esta categoría?')) return;
+  const handleDelete = async (category: Category) => {
+    const childCount = category.children?.length ?? 0;
+    const warning = childCount > 0
+      ? `¿Eliminar “${category.name}” y sus ${childCount} subcategorías? También se retirarán sus asociaciones con productos.`
+      : `¿Eliminar “${category.name}”? También se retirarán sus asociaciones con productos.`;
+    if (!confirm(warning)) return;
+    setDeletingId(category.id);
+    setMsg('');
     try {
-      await categoriesApi.delete(id);
-      load();
+      await categoriesApi.delete(category.id);
+      setMsg(`Categoría “${category.name}” eliminada`);
+      await load();
     } catch (e) {
-      alert(e instanceof Error ? e.message : 'Error al eliminar');
+      setMsg(`Error al eliminar: ${e instanceof Error ? e.message : 'Error desconocido'}`);
+    } finally {
+      setDeletingId(null);
     }
   };
 
@@ -507,7 +517,7 @@ export default function CategoriesPage() {
             </thead>
             <tbody className="divide-y divide-gray-50">
               {flat(tree).map((c) => (
-                <CategoryRow key={c.id} cat={c} onEdit={openEdit} onDelete={handleDelete} />
+                <CategoryRow key={c.id} cat={c} onEdit={openEdit} onDelete={handleDelete} deleting={deletingId === c.id} />
               ))}
             </tbody>
           </table>
diff --git a/project/apps/admin/src/lib/api-client.ts b/project/apps/admin/src/lib/api-client.ts
index cbc2602..4831bc9 100644
--- a/project/apps/admin/src/lib/api-client.ts
+++ b/project/apps/admin/src/lib/api-client.ts
@@ -36,6 +36,7 @@ async function request<T>(method: string, path: string, body?: unknown): Promise
     );
   }
 
+  if (res.status === 204) return undefined as T;
   return res.json() as Promise<T>;
 }
 
diff --git a/work/artifacts/F-170/architect.md b/work/artifacts/F-170/architect.md
new file mode 100644
index 0000000..2f7b5bd
--- /dev/null
+++ b/work/artifacts/F-170/architect.md
@@ -0,0 +1,3 @@
+# F-170
+
+Handle no-content centrally; category deletion retains server RBAC/cascade and explicit UI confirmation.
diff --git a/work/artifacts/F-170/documenter.md b/work/artifacts/F-170/documenter.md
new file mode 100644
index 0000000..1ef7142
--- /dev/null
+++ b/work/artifacts/F-170/documenter.md
@@ -0,0 +1,3 @@
+# F-170
+
+Categorías se eliminan con confirmación y mensaje visible.
diff --git a/work/artifacts/F-170/implementer.md b/work/artifacts/F-170/implementer.md
new file mode 100644
index 0000000..0bf20b4
--- /dev/null
+++ b/work/artifacts/F-170/implementer.md
@@ -0,0 +1,3 @@
+# F-170
+
+Admin API client now accepts 204 without JSON parsing. Category delete warns about cascading children/product associations, prevents duplicate click, reloads and gives inline feedback. Runtime create 201/delete 204 empty body. Admin build/typecheck pass.
diff --git a/work/artifacts/F-170/leader-close.json b/work/artifacts/F-170/leader-close.json
new file mode 100644
index 0000000..c33c0fd
--- /dev/null
+++ b/work/artifacts/F-170/leader-close.json
@@ -0,0 +1 @@
+{"feature_id":"F-170","agent":"leader","stage":"close","verdict":"APPROVED","checks":[{"item":"all gates/runtime/verify","ok":true}],"issues":[]}
diff --git a/work/artifacts/F-170/qa.json b/work/artifacts/F-170/qa.json
new file mode 100644
index 0000000..dfb2f4a
--- /dev/null
+++ b/work/artifacts/F-170/qa.json
@@ -0,0 +1 @@
+{"feature_id":"F-170","agent":"qa","stage":"qa_gate","verdict":"APPROVED","checks":[{"item":"create/delete runtime","ok":true},{"item":"build/typecheck","ok":true}],"issues":[]}
diff --git a/work/artifacts/F-170/reviewer.json b/work/artifacts/F-170/reviewer.json
new file mode 100644
index 0000000..d5e780c
--- /dev/null
+++ b/work/artifacts/F-170/reviewer.json
@@ -0,0 +1 @@
+{"feature_id":"F-170","agent":"reviewer","stage":"review_gate","verdict":"APPROVED","checks":[{"item":"204 handling","ok":true},{"item":"guarded UI feedback","ok":true}],"issues":[]}
diff --git a/work/artifacts/F-170/security.json b/work/artifacts/F-170/security.json
new file mode 100644
index 0000000..860f139
--- /dev/null
+++ b/work/artifacts/F-170/security.json
@@ -0,0 +1 @@
+{"feature_id":"F-170","agent":"security","stage":"security_gate","verdict":"APPROVED","checks":[{"item":"server admin RBAC retained","ok":true}],"issues":[]}
diff --git a/work/current.md b/work/current.md
index e5cd44e..8342941 100644
--- a/work/current.md
+++ b/work/current.md
@@ -1,3 +1,3 @@
-# F-183 — Repair Almagro and storefront LAN development
+# F-170 — Delete categories
 
-Recompile Almagro with fontTools to regenerate valid cmap/table directories and WOFF2 container. Permit the configured LAN host as a Next development origin so chunks and HMR websocket are accepted.
+Admin client must treat HTTP 204 as success instead of attempting JSON parsing. Category UI confirms cascading impact, disables duplicate deletion, reloads tree and shows persistent success/error feedback.
diff --git a/work/runtime-status.json b/work/runtime-status.json
index 5ccc595..4c36899 100644
--- a/work/runtime-status.json
+++ b/work/runtime-status.json
@@ -1,64 +1,64 @@
 {
-  "feature_id": "F-183",
+  "feature_id": "F-170",
   "stage": "close",
   "agent": "leader",
   "action": "close",
   "state": "running",
   "next_agent": "leader",
   "waiting_for": "Seleccionar una feature pending y actualizar este estado",
-  "updated_at": "2026-08-22T17:11:58Z",
+  "updated_at": "2026-08-22T17:13:31Z",
   "timeline": [
     {
-      "ts": "2026-08-22T17:10:44Z",
+      "ts": "2026-08-22T17:12:20Z",
       "agent": "leader",
       "stage": "intake",
       "state": "running",
-      "message": "Repair font tables and LAN dev origin"
+      "message": "Fix category delete 204 handling"
     },
     {
-      "ts": "2026-08-22T17:10:44Z",
+      "ts": "2026-08-22T17:12:20Z",
       "agent": "architect",
       "stage": "design",
       "state": "running",
       "message": "design"
     },
     {
-      "ts": "2026-08-22T17:10:44Z",
+      "ts": "2026-08-22T17:12:20Z",
       "agent": "implementer",
       "stage": "build",
       "state": "running",
-      "message": "Recompile font and allow LAN dev origin"
+      "message": "Implement reliable category deletion"
     },
     {
-      "ts": "2026-08-22T17:11:58Z",
+      "ts": "2026-08-22T17:13:31Z",
       "agent": "reviewer",
       "stage": "review_gate",
       "state": "running",
       "message": "review"
     },
     {
-      "ts": "2026-08-22T17:11:58Z",
+      "ts": "2026-08-22T17:13:31Z",
       "agent": "security",
       "stage": "security_gate",
       "state": "running",
       "message": "security"
     },
     {
-      "ts": "2026-08-22T17:11:58Z",
+      "ts": "2026-08-22T17:13:31Z",
       "agent": "qa",
       "stage": "qa_gate",
       "state": "running",
       "message": "qa"
     },
     {
-      "ts": "2026-08-22T17:11:58Z",
+      "ts": "2026-08-22T17:13:31Z",
       "agent": "documenter",
       "stage": "document",
       "state": "running",
       "message": "document"
     },
     {
-      "ts": "2026-08-22T17:11:58Z",
+      "ts": "2026-08-22T17:13:31Z",
       "agent": "leader",
       "stage": "close",
       "state": "running",