feat(F-115): completed feature
This commit is contained in:
@@ -41,7 +41,6 @@ import type { Product } from '../domain/product.js';
|
||||
import { PRODUCT_ATTRIBUTES, PRODUCT_STATES } from '../domain/product.js';
|
||||
import type { ProductRichData, ProductVariant } from '../domain/variant.js';
|
||||
import { NUTRITION_SOURCES } from '../domain/variant.js';
|
||||
import { generateSkuFromTitle, uniqueSku } from '../domain/sku.js';
|
||||
import { LocalProductImageStorage } from '../infrastructure/local-product-image-storage.js';
|
||||
import { PgProductImageRepository } from '../infrastructure/pg-product-image-repository.js';
|
||||
import { PgProductRepository } from '../infrastructure/pg-product-repository.js';
|
||||
@@ -373,40 +372,6 @@ export async function registerCatalogRoutes(
|
||||
return reply.send({ suggestions });
|
||||
});
|
||||
|
||||
// ── Sugerir SKU (F-100) ─────────────────────────────────────────────────
|
||||
const generateSkuSchema: FastifySchema = {
|
||||
tags: ['Admin Products'],
|
||||
summary: 'Suggest a SKU from a product title',
|
||||
description: 'Genera un SKU a partir del título y garantiza que no colisiona con los SKUs existentes.',
|
||||
body: {
|
||||
type: 'object',
|
||||
required: ['title'],
|
||||
properties: { title: { type: 'string', minLength: 1, maxLength: 200 } },
|
||||
},
|
||||
response: { 200: { type: 'object' }, 401: errorSchema, 403: errorSchema, 422: errorSchema },
|
||||
};
|
||||
app.post('/products/sku:generate', { schema: generateSkuSchema }, async (request, reply) => {
|
||||
const user = await deps.authenticate(request);
|
||||
requireRole(user, 'admin');
|
||||
const { title } = parseJson(
|
||||
z.object({ title: z.string().min(1).max(200) }),
|
||||
request.body,
|
||||
);
|
||||
let base: string;
|
||||
try {
|
||||
base = generateSkuFromTitle(title);
|
||||
} catch (error) {
|
||||
throw new AppError(
|
||||
422,
|
||||
'INVALID_TITLE',
|
||||
error instanceof Error ? error.message : 'Invalid title',
|
||||
);
|
||||
}
|
||||
const taken = new Set(await variants.listAllSkus());
|
||||
const sku = uniqueSku(base, taken);
|
||||
return reply.send({ sku });
|
||||
});
|
||||
|
||||
const createProductSchema: FastifySchema = {
|
||||
tags: ['Admin Products'],
|
||||
summary: 'Create product',
|
||||
@@ -420,13 +385,10 @@ export async function registerCatalogRoutes(
|
||||
const input = parseJson(newProductSchema, request.body);
|
||||
try {
|
||||
const product = await createProduct.execute(input);
|
||||
// Cada producto lleva una única variante interna autogenerada con un
|
||||
// SKU derivado del título (F-100). El admin puede editarlo después.
|
||||
// Modelo sin variantes visibles: cada producto lleva una única variante
|
||||
// interna autogenerada (SKU interno, nunca editable).
|
||||
try {
|
||||
const base = generateSkuFromTitle(product.name);
|
||||
const taken = new Set(await variants.listAllSkus());
|
||||
const sku = uniqueSku(base, taken);
|
||||
await createVariant.execute(product.id, { sku });
|
||||
await createVariant.execute(product.id, { sku: `SKU-MV-${product.id}` });
|
||||
} catch (variantError) {
|
||||
request.log.warn({ err: variantError, productId: product.id }, 'default_variant_create_failed');
|
||||
}
|
||||
@@ -455,14 +417,8 @@ export async function registerCatalogRoutes(
|
||||
try {
|
||||
const user = await deps.authenticate(request);
|
||||
if (user.role === 'admin') {
|
||||
const product = await repository.findById(id);
|
||||
if (product) {
|
||||
const base = generateSkuFromTitle(product.name);
|
||||
const taken = new Set(await variants.listAllSkus());
|
||||
const sku = uniqueSku(base, taken);
|
||||
const created = await createVariant.execute(id, { sku });
|
||||
if (created) items = [created];
|
||||
}
|
||||
const created = await createVariant.execute(id, { sku: `SKU-MV-${id}` });
|
||||
if (created) items = [created];
|
||||
}
|
||||
} catch {
|
||||
// Sin sesión admin: se devuelve la lista vacía sin crear nada.
|
||||
|
||||
@@ -40,8 +40,6 @@ export interface ProductVariantRepository {
|
||||
variantId: string,
|
||||
patch: ProductVariantPatch,
|
||||
): Promise<ProductVariant | undefined>;
|
||||
/** Returns all SKUs (uppercase preserved) currently in use. */
|
||||
listAllSkus(): Promise<string[]>;
|
||||
}
|
||||
|
||||
export interface ProductRichDataRepository {
|
||||
|
||||
@@ -27,13 +27,6 @@ const UPDATABLE: ReadonlyArray<[keyof ProductVariantPatch, string]> = [
|
||||
export class PgProductVariantRepository implements ProductVariantRepository {
|
||||
constructor(private readonly pool: pg.Pool) {}
|
||||
|
||||
async listAllSkus(): Promise<string[]> {
|
||||
const result = await this.pool.query<{ sku: string }>(
|
||||
'SELECT sku FROM catalog_product_variants',
|
||||
);
|
||||
return result.rows.map((row) => row.sku);
|
||||
}
|
||||
|
||||
async listByProductId(productId: string): Promise<ProductVariant[]> {
|
||||
const result = await this.pool.query<VariantRow>(
|
||||
'SELECT * FROM catalog_product_variants WHERE product_id = $1 ORDER BY created_at, sku',
|
||||
|
||||
Reference in New Issue
Block a user