feat(F-081): completed feature

This commit is contained in:
chattie
2026-08-20 06:01:32 +02:00
parent 506dfd0cce
commit baec2a43c3
9 changed files with 184 additions and 24 deletions

View File

@@ -0,0 +1,45 @@
# F-081 — Architect: Inventory PRECIO NETO wrong format and no save
## Root cause
`InventorySection.tsx` (the inventory tab inside the product editor) initialises `priceValue` with `String(price.netUnitAmountCents)`. The input is `type="number"` so it shows a cents value (`1000` for €10.00), and `savePrice` reads it back with `parseInt(r.priceValue, 10)` which it sends as cents. Two consequences:
1. The visible number (1000) does not look like a price — operators either type "10" thinking euros and end up saving 10 cents, or paste euros and corrupt the price.
2. The OK button *does* exist and *does* call PATCH /variants/:id/set-price, but the persisted value is wrong by ~100x.
The Prices tab (PricingSection.tsx) already does this right with `centsToEur` and `eurToCents` helpers — same component pattern should be reused here.
## Design
Inventory-only fix in `InventorySection.tsx`:
1. Add two local helpers (mirroring PricingSection):
```ts
const centsToEur = (cents: number) => (cents / 100).toFixed(2);
const eurToCents = (input: string) => {
if (!input) return 0;
const v = parseFloat(String(input).replace(',', '.'));
return isNaN(v) ? 0 : Math.round(v * 100);
};
```
2. Initialise `priceValue` from `centsToEur(price.netUnitAmountCents)`.
3. Display the read-only cell with `formatCents` (already exists) — no change.
4. Edit cell: switch `<input type="number">` to `<input type="text" inputMode="decimal">` so comma/dot are accepted and digits can be deleted freely (same UX as PricingSection).
5. `savePrice`: parse with `eurToCents(r.priceValue)` → call existing `pricingApi.setVariantPrice(variantId, cents, r.vatRate)` (no contract change).
6. `cancelEditPrice`: restore from `r.price.netUnitAmountCents` using `centsToEur`.
7. On save success, refresh `priceValue` from the cents returned by the API so the cell shows exactly what was persisted.
The standalone `/inventory` page is **not** affected — it doesn't render Precio Neto at all (out of F-081 scope; addressed in F-082 for the InventorySection row when needed).
## Risk
Low. Behaviour-equivalent on the wire: cents go to the same endpoint. Format-only change in the cell.
## Acceptance mapping
- "Inventory PRECIO NETO accepts ',' and '.' as decimal separator" → `type="text"` + `eurToCents`.
- "Operator can freely type, delete digits and decimal separator" → text input + state-driven value.
- "Editing triggers PATCH /variants/:id" → existing `savePrice` flow.
- "On success the new value is persisted and shown back" → `setRows` updates `price.netUnitAmountCents` and `priceValue` to the API-returned cents.
- "On error inline error is shown and old value is restored" → existing `saveMsg` + `cancelEditPrice` pattern.
- "Format identical to Prices tab Neto (sin IVA)" → uses `centsToEur` and `eurToCents` mirroring PricingSection.
- "verify.sh is green" → typecheck + lint clean.

View File

@@ -0,0 +1,34 @@
# F-081 — Implementer evidence
## What was implemented
The inventory tab inside the product editor (`InventorySection.tsx`) stored `priceValue` as **cents-as-string** (e.g. `1000` for €10.00) and `savePrice` parsed it with `parseInt` treating the input as cents. Operators typing `10,50` saw the wrong number in the cell and the PATCH sent `1050` cents (€10.50) or worse.
Now the field stores the price as a **euros-as-string** like PricingSection, with a matching parser/converter.
### Files changed
- `project/apps/admin/src/features/products/components/sections/InventorySection.tsx`
- Added two local helpers:
- `centsToEur(cents)`: `(cents / 100).toFixed(2)``"10.50"`.
- `eurToCents(input)`: parses `"12"`, `"12,30"`, `"12.30"`, returns cents.
- `priceValue` initial value on price load now comes from `centsToEur(price.netUnitAmountCents)`.
- `cancelEditPrice` restores `priceValue` via `centsToEur(...)` from the persisted price.
- `savePrice` parses with `eurToCents(r.priceValue)` (was `parseInt` on cents). After a successful API response, `priceValue` is normalised from `result.netUnitAmountCents`.
- The edit input switched from `type="number"` to `type="text" inputMode="decimal"` so commas and dots are accepted and digits can be deleted freely.
- Removed unused `useCallback` import and the unused `grossPrice` local (pre-existing lint debt) to keep lint clean.
## Validation
- `npx tsc --noEmit` → exit 0
- `npx eslint` on changed file → exit 0
- Vitest unchanged (UI-only change).
## Acceptance trace
- "Inventory PRECIO NETO input accepts ',' and '.' as decimal separator" → `type="text"` + `eurToCents` parses both.
- "Operator can freely type, delete digits and the decimal separator" → state-driven text input.
- "Editing PRECIO NETO triggers a PATCH to the variant endpoint with the new netUnitAmount" → `savePrice``pricingApi.setVariantPrice`.
- "On success the new value is persisted and shown back in the cell; on error inline error and old value" → `setRows(...price: result, priceValue: centsToEur(result.netUnitAmountCents))`; on error existing `saveMsg = 'Error'` + `cancelEditPrice` restore path.
- "Format identical to Prices tab Neto (sin IVA)" → uses the same `centsToEur`/`eurToCents` helpers.
- "verify.sh is green" → typecheck + lint clean.

View File

@@ -0,0 +1,14 @@
{
"feature_id": "F-081",
"agent": "leader",
"verdict": "APPROVED",
"summary": "All gates approved. F-081 fixes InventorySection PRECIO NETO to use euros-as-string and mirrors the Prices tab input behaviour; saves via existing PATCH endpoint.",
"evidence": [
"work/artifacts/F-081/reviewer.json verdict=APPROVED",
"work/artifacts/F-081/security.json verdict=APPROVED",
"work/artifacts/F-081/qa.json verdict=APPROVED",
"npx tsc --noEmit exit 0",
"npx eslint exit 0"
],
"timestamp": "2026-08-20T04:04:30Z"
}

View File

@@ -0,0 +1,20 @@
{
"feature_id": "F-081",
"verdict": "APPROVED",
"trace": [
{ "acceptance": "Inventory PRECIO NETO accepts ',' and '.'", "result": "PASS", "evidence": "eurToCents replaces ',' with '.' before parseFloat." },
{ "acceptance": "Operator can freely type, delete digits and decimal separator", "result": "PASS", "evidence": "type=text inputMode=decimal; value bound to priceValue state." },
{ "acceptance": "Editing triggers PATCH to the variant endpoint", "result": "PASS", "evidence": "savePrice -> pricingApi.setVariantPrice(variantId, cents, vatRate)." },
{ "acceptance": "On success value is persisted and shown back; on error inline error and old value restored", "result": "PASS", "evidence": "setRows updates price + priceValue from API response on success; saveMsg = 'Error' on failure; cancelEditPrice restores from r.price." },
{ "acceptance": "Format identical to Prices tab Neto (sin IVA)", "result": "PASS", "evidence": "Same centsToEur/eurToCents behaviour; same input attributes." },
{ "acceptance": "verify.sh is green", "result": "PASS", "evidence": "tsc --noEmit exit 0; eslint exit 0." }
],
"regression_checks": [
"IVA dropdown still editable",
"Stock edit still works",
"Cancel button still restores"
],
"verdict_reason": "Format-only fix. All acceptance criteria trace to PASS.",
"reviewer": "qa",
"reviewed_at": "2026-08-20T04:04:00Z"
}

View File

@@ -0,0 +1,16 @@
{
"feature_id": "F-081",
"verdict": "APPROVED",
"checks": [
{ "name": "priceValue is euros string, not cents string", "result": "PASS", "notes": "centsToEur on load and on success. eurToCents on save." },
{ "name": "type=text inputMode=decimal", "result": "PASS", "notes": "Same component shape as PricingSection's Neto input." },
{ "name": "PATCH still posts cents to pricingApi", "result": "PASS", "notes": "endpoint and payload unchanged: { netUnitAmountCents, vatRate }." },
{ "name": "Cancel restores the previously-persisted value", "result": "PASS", "notes": "cancelEditPrice uses centsToEur(r.price.netUnitAmountCents)." },
{ "name": "Pre-existing lint cleaned", "result": "PASS", "notes": "Removed unused useCallback import and grossPrice local." }
],
"lint": { "errors_introduced": 0, "pre_existing_cleaned": true },
"typecheck": "PASS",
"verdict_reason": "Format and save behaviour now match Prices tab exactly.",
"reviewer": "reviewer",
"reviewed_at": "2026-08-20T04:03:00Z"
}

View File

@@ -0,0 +1,15 @@
{
"feature_id": "F-081",
"verdict": "APPROVED",
"checks": [
{ "name": "XSS / parser safety", "result": "PASS", "notes": "eurToCents uses parseFloat; result is a number, never rendered as HTML." },
{ "name": "Auth unchanged", "result": "PASS", "notes": "Same admin-gated endpoint." },
{ "name": "No new dependencies", "result": "PASS", "notes": "No new packages." }
],
"sast": "PASS",
"dependency_review": "PASS",
"secret_scan": "PASS",
"verdict_reason": "Format-only UI change; no new attack surface.",
"reviewer": "security",
"reviewed_at": "2026-08-20T04:03:30Z"
}

View File

@@ -1,20 +1,13 @@
{
"feature_id": "F-080",
"stage": "close",
"agent": "leader",
"action": "closing F-080",
"feature_id": "F-081",
"stage": "build",
"agent": "implementer",
"action": "fixing inventory price format",
"state": "running",
"next_agent": "reviewer",
"waiting_for": null,
"updated_at": "2026-08-20T03:59:44Z",
"updated_at": "2026-08-20T04:00:42Z",
"timeline": [
{
"ts": "2026-08-19T17:29:19Z",
"agent": "leader",
"stage": "intake",
"state": "running",
"message": "starting F-076"
},
{
"ts": "2026-08-19T17:29:19Z",
"agent": "architect",
@@ -147,6 +140,13 @@
"stage": "close",
"state": "running",
"message": "closing F-080"
},
{
"ts": "2026-08-20T04:00:42Z",
"agent": "implementer",
"stage": "build",
"state": "running",
"message": "fixing inventory price format"
}
],
"last_updated": "2026-08-19T09:10:00Z",