feat(F-195): completed feature
This commit is contained in:
11
work/artifacts/F-195/implementer.md
Normal file
11
work/artifacts/F-195/implementer.md
Normal file
@@ -0,0 +1,11 @@
|
||||
# F-195 — Fix evidence
|
||||
|
||||
**Issue**: After F-194, IVA / Auditoría / Logs still appeared as top-level items in the main admin sidebar because their entries remained in `NAV_ITEMS`.
|
||||
|
||||
**Change** (`project/apps/admin/src/lib/permissions.ts`):
|
||||
- Removed `IVA`, `Auditoría`, `Logs` entries from `NAV_ITEMS`. They no longer appear in the main sidebar.
|
||||
- Added `SETTINGS_SUB_NAV_ITEMS` constant exposing the same routes so they can be consumed by the Settings sub-nav (already implemented in F-194 in `settings/page.tsx`).
|
||||
- Routes (`/settings/tax-rates`, `/settings/audit`, `/settings/logs`) remain accessible via in-page links from the Settings sidebar.
|
||||
|
||||
**Validation**:
|
||||
- admin typecheck: PASS
|
||||
1
work/artifacts/F-195/leader-close.json
Normal file
1
work/artifacts/F-195/leader-close.json
Normal file
@@ -0,0 +1 @@
|
||||
{"feature_id":"F-195","agent":"leader","stage":"close","verdict":"APPROVED","checks":[{"item":"All gates APPROVED","ok":true}],"issues":[]}
|
||||
1
work/artifacts/F-195/qa.json
Normal file
1
work/artifacts/F-195/qa.json
Normal file
@@ -0,0 +1 @@
|
||||
{"feature_id":"F-195","agent":"qa","stage":"qa_gate","verdict":"APPROVED","acceptance":[{"id":1,"criterion":"Main sidebar does not show IVA/Audit/Logs","ok":true},{"id":2,"criterion":"Sub-pages still reachable from Settings page","ok":true}],"issues":[]}
|
||||
1
work/artifacts/F-195/reviewer.json
Normal file
1
work/artifacts/F-195/reviewer.json
Normal file
@@ -0,0 +1 @@
|
||||
{"feature_id":"F-195","agent":"reviewer","stage":"review_gate","verdict":"APPROVED","checks":[{"item":"IVA/Audit/Logs removed from NAV_ITEMS","ok":true},{"item":"Routes still exist under /settings/...","ok":true},{"item":"typecheck passes","ok":true}],"issues":[]}
|
||||
1
work/artifacts/F-195/security.json
Normal file
1
work/artifacts/F-195/security.json
Normal file
@@ -0,0 +1 @@
|
||||
{"feature_id":"F-195","agent":"security","stage":"security_gate","verdict":"APPROVED","checks":[{"item":"No new attack surface","ok":true}],"issues":[]}
|
||||
@@ -508,3 +508,7 @@
|
||||
- Fix 1: replaced bare crypto.randomUUID() with generateIdempotencyKey() in PaymentModal and terminal page.
|
||||
- Fix 2: moved tax-rates, audit and logs routes from top-level dashboard into /settings/... with breadcrumb navigation.
|
||||
- Evidencia: admin/POS typecheck and builds green; 268/268 unit tests pass; verify.sh green.
|
||||
|
||||
## F-195 cerrada (2026-08-22) — Hide IVA/Audit/Logs from main sidebar
|
||||
- Gates: reviewer APPROVED, security APPROVED, qa APPROVED, verify.sh exit 0.
|
||||
- Fix: removed IVA/Auditoría/Logs from NAV_ITEMS so they no longer appear in main sidebar; routes still accessible via in-page links from /settings.
|
||||
|
||||
@@ -6,6 +6,6 @@
|
||||
"state": "waiting",
|
||||
"next_agent": "leader",
|
||||
"waiting_for": "Seleccionar una feature pending y actualizar este estado",
|
||||
"updated_at": "2026-08-22T20:29:26Z",
|
||||
"updated_at": "2026-08-22T20:36:05Z",
|
||||
"timeline": []
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user