24 lines
1.8 KiB
JSON
24 lines
1.8 KiB
JSON
{
|
|
"feature_id": "F-017",
|
|
"agent": "reviewer",
|
|
"verdict": "APPROVED",
|
|
"summary": "F-017 review approved. The pricing module is isolated, exposes a public PricingService contract, calculates VAT using integer cents from persisted server-side prices, strips client-supplied price fields from calculate requests, and writes append-only history on every price change.",
|
|
"evidence": [
|
|
"Read work/current.md, architect.md and implementer.md",
|
|
"Inspected pricing domain/application/infrastructure/API files: public API exported from index.ts; internals stay inside modules/pricing",
|
|
"Inspected PricingService: calculation uses persisted VariantPrice plus quantity only; money is integer cents; VAT basis points are explicit",
|
|
"Inspected pricing routes: /pricing/calculate schema strips extra fields and never accepts client totals as truth",
|
|
"Inspected PgPricingRepository: setVariantPrice locks current row and writes pricing_price_history inside the same transaction",
|
|
"Inspected migration 012_pricing.js: current price table and append-only history table with VAT/currency/amount constraints",
|
|
"Inspected boundary test: catalog source scan blocks pricing table references and pricing internal imports",
|
|
"gentle-ai review mode status: receipt-driven development off globally, ordinary Orquestra gate used",
|
|
"cd project && npm run lint passed",
|
|
"cd project && npm run typecheck passed",
|
|
"cd project && npm run build passed",
|
|
"cd project && npm test passed; DB integration tests skipped without TEST_DATABASE_URL",
|
|
"cd project && TEST_DATABASE_URL='postgres://mdv:mdv_dev_only@localhost:5432/mdv_test' npm run test:integration -- pricing.itest migrations.itest passed",
|
|
"./scripts/verify.sh passed"
|
|
],
|
|
"timestamp": "2026-08-15T16:24:16Z"
|
|
}
|