18 lines
1.8 KiB
JSON
18 lines
1.8 KiB
JSON
{
|
|
"feature_id": "F-144",
|
|
"agent": "reviewer",
|
|
"stage": "review_gate",
|
|
"verdict": "APPROVED",
|
|
"summary": "Additive schema migration 048 adds store_id/shipping_cents/cost_at_sale_cents/vat_rate snapshot columns + FK/index, with itest verifying schema via information_schema/pg_constraint/pg_indexes. Backend-only, no API change. Idempotency/reversibility correct and matching architect.md. INSERT adapts to the 047 CHECK.",
|
|
"checks": [
|
|
{"item": "AC1 store_id col+FK+index+backfill", "ok": true, "evidence": "information_schema.columns is_nullable=NO column_default contains DEFAULT_STORE_ID; pg_constraint contype='f' (store_id_fkey); pg_indexes index; INSERT backfill asserts store_id=DEFAULT_STORE_ID (itest 3/3)"},
|
|
{"item": "AC2 shipping_cents NOT NULL DEFAULT 0", "ok": true, "evidence": "column_info is_nullable=NO default 0; INSERT backfill asserts shipping_cents=0"},
|
|
{"item": "AC3 line snapshots nullable", "ok": true, "evidence": "orders_items cost_at_sale_cents(bigint is_nullable=YES) + vat_rate(text is_nullable=YES)"},
|
|
{"item": "AC4 idempotent/reversible", "ok": true, "evidence": "up uses ADD COLUMN IF NOT EXISTS + DO$$ FK guard; down drops index/constraint/columns via IF EXISTS; re-run up is no-op"},
|
|
{"item": "No API/user-facing change", "ok": true, "evidence": "migration + itest only; reporting.routes.ts / reporting.index.ts unchanged vs F-143"},
|
|
{"item": "No new boundary violation", "ok": true, "evidence": "git diff touches migrations/048.js + tests/reporting-snapshots.itest.ts only; 0 new src module imports; check-module-boundaries 0 new (R1 security.routes→log-broadcaster pre-existing)"},
|
|
{"item": "Lint/TS/verify", "ok": true, "evidence": "tsc --noEmit 0 errors; boundaries 0 new; verify.sh exit 0"}
|
|
],
|
|
"issues": []
|
|
}
|